This repository was archived by the owner on Mar 10, 2025. It is now read-only.
mri, initial offsets #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/hermann/consumer.rb
Outdated
There was a problem hiding this comment.
Would you mind typing this exception and defining it in lib/hermann/errors.rb?
|
After this change is merged, I'll cut a new release to rubygems.org since my magic auto-deploy stuff isn't entirely working correctly |
Contributor
Author
|
updated, thanks for the review! |
spec/consumer_spec.rb
Outdated
There was a problem hiding this comment.
Looks like this test needs to be updated per Travis failures
Contributor
Author
|
yup, sorry. fixed now. |
|
0.23.242 contains this change |
Contributor
Author
|
awesome, thanks much @rtyler |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow the consumer to choose an initial offset position on mri. this can be either
:start,:end, or a fixnum position. would do the same for the jruby client if it was thought valuable, but I'd need to go poke into the interface.